fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-06 00:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

iris: Rewrite bo->index comment to refer to exec_bos[]

Browse source 
batch->validation_list[] will be going away shortly, but exec_bos[]
will live on.  bo->index is the index into both lists, so we can just
refer to the one we're not about to delete.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12848>
This commit is contained in:
Kenneth Graunke 2021-08-04 10:47:31 -07:00 • committed by Marge Bot
parent 4149a60209
commit 795b14aaa3
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/gallium/drivers/iris/iris_bufmgr.h
View file

@ -176,12 +176,13 @@ struct iris_bo {
uint64_t aux_map_address;
/**
* The validation list index for this buffer, or -1 when not in a batch.
* Note that a single buffer may be in multiple batches (contexts), and
* this is a global field, which refers to the last batch using the BO.
* It should not be considered authoritative, but can be used to avoid a
* linear walk of the validation list in the common case by guessing that
* exec_bos[bo->index] == bo and confirming whether that's the case.
* If this BO is referenced by a batch, this _may_ be the index into the
* batch->exec_bos[] list.
*
* Note that a single buffer may be used by multiple batches/contexts,
* and thus appear in multiple lists, but we only track one index here.
* In the common case one can guess that batch->exec_bos[bo->index] == bo
* and double check if that's true to avoid a linear list walk.
*
* XXX: this is not ideal now that we have more than one batch per context,
* XXX: as the index will flop back and forth between the render index and