fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 07:28:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

aco: add more validation rules for SDWA operands

Browse source 
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12364>
This commit is contained in:
Daniel Schürmann 2021-08-18 21:42:15 +02:00 • committed by Marge Bot
parent 077776a866
commit 77ffdf41b1
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/amd/compiler/aco_validate.cpp
View file

@ -165,6 +165,15 @@ validate_ir(Program* program)
"SDWA+VOPC definition must be fixed to vcc on GFX8", instr.get());
}
for (unsigned i = 0; i < std::min<unsigned>(2, instr->operands.size()); i++) {
const Operand& op = instr->operands[i];
check(op.bytes() <= 4, "SDWA operands must not be larger than 4 bytes", instr.get());
if (sdwa.sel[i] & sdwa_isra)
check(op.bytes() >= (sdwa.sel[i] & sdwa_rasize),
"SDWA selection size must be at most operand size", instr.get());
else
check(op.bytes() == 4, "SDWA selection needs dword operand", instr.get());
}
if (instr->operands.size() >= 3) {
check(instr->operands[2].isFixed() && instr->operands[2].physReg() == vcc,
"3rd operand must be fixed to vcc with SDWA", instr.get());
@ -681,8 +690,8 @@ validate_subdword_operand(chip_class chip, const aco_ptr<Instruction>& instr, un
if (instr->isPseudo() && chip >= GFX8)
return true;
if (instr->isSDWA()) {
unsigned sel = instr->sdwa().sel[index] & sdwa_asuint;
return (sel & sdwa_isra) && (sel & sdwa_rasize) <= op.bytes();
unsigned size = instr->sdwa().sel[index] & sdwa_rasize;
return byte % size == 0;
}
if (byte == 2 && can_use_opsel(chip, instr->opcode, index, 1))
return true;