fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 11:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

broadcom/compiler: add comment on why we don't use r5 with ldunifa

Browse source 
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15276>
This commit is contained in:
Iago Toral Quiroga 2022-03-07 14:03:03 +01:00 • committed by Marge Bot
parent 5b140428b0
commit 77f58b46d9
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/broadcom/compiler/vir_register_allocate.c
View file

@ -916,6 +916,11 @@ update_graph_and_reg_classes_for_inst(struct v3d_compile *c, int *acc_nodes,
if (inst->dst.file == QFILE_TEMP) {
/* Only a ldunif gets to write to R5, which only has a
* single 32-bit channel of storage.
*
* NOTE: ldunifa is subject to the same, however, going by
* shader-db it is best to keep r5 exclusive to ldunif, probably
* because ldunif has usually a shorter lifespan, allowing for
* more accumulator reuse and QPU merges.
*/
if (!inst->qpu.sig.ldunif) {
uint8_t class_bits =