From 76e3b482be125cc0a2edd75bdeb14d4a6e9232fb Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 1 Nov 2022 12:40:21 -0700 Subject: [PATCH] util/glsl2spirv: fix type error in argument handling args.Olib is set to `store_true`, which means it will always be `True` or `False`, this means that the we always, unconditionally, add `--keep-uncalled` to the command line. fixes: 9786d9ef2abb45a4e832cf1347581e3ca3aae9f0 Reviewed-by: Luis Felipe Strano Moraes Part-of: --- src/util/glsl2spirv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/glsl2spirv.py b/src/util/glsl2spirv.py index f11bf612cb1..8b765c987eb 100644 --- a/src/util/glsl2spirv.py +++ b/src/util/glsl2spirv.py @@ -129,7 +129,7 @@ def process_file(args): cmd_list = ["glslangValidator"] - if args.Olib is not None: + if args.Olib: cmd_list += ["--keep-uncalled"] if args.vn is not None: