anv: emit pixel scoreboard stall before ISP disable

We want to make sure that all indirect state data has been loaded into
the EUs before disable the pointers.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>
Fixes: 78c125af39 ("anv/gen10: Ignore push constant packets during context restore.")
This commit is contained in:
Lionel Landwerlin 2018-05-08 17:25:55 +01:00
parent f536097f67
commit 766d801ca3

View file

@ -1420,14 +1420,21 @@ genX(BeginCommandBuffer)(
* context restore, so the mentioned hang doesn't happen. However, * context restore, so the mentioned hang doesn't happen. However,
* software must program push constant commands for all stages prior to * software must program push constant commands for all stages prior to
* rendering anything. So we flag them dirty in BeginCommandBuffer. * rendering anything. So we flag them dirty in BeginCommandBuffer.
*
* Finally, we also make sure to stall at pixel scoreboard to make sure the
* constants have been loaded into the EUs prior to disable the push constants
* so that it doesn't hang a previous 3DPRIMITIVE.
*/ */
static void static void
emit_isp_disable(struct anv_cmd_buffer *cmd_buffer) emit_isp_disable(struct anv_cmd_buffer *cmd_buffer)
{ {
anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) { anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) {
pc.IndirectStatePointersDisable = true; pc.StallAtPixelScoreboard = true;
pc.CommandStreamerStallEnable = true; pc.CommandStreamerStallEnable = true;
} }
anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) {
pc.IndirectStatePointersDisable = true;
}
} }
VkResult VkResult