fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-03 15:50:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tu: Expose VK_KHR_spirv_1_4 and VK_EXT_scalar_block_layout

Browse source 
VK_KHR_spirv_1_4 is trivial because vtn already supports all the added
SPIR-V features that aren't gated behind Vulkan extensions. I've
observed some robustness2 CTS tests requiring this. However there are
a few tests currently failing due to lacking spilling.

VK_EXT_scalar_block_layout should also be trivial, since support for
"straddling" UBO loads was added recently for other reasons. This is
used by every robustness2 CTS test.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8695>
This commit is contained in:
Connor Abbott 2020-12-03 11:46:48 +01:00 • committed by Marge Bot
parent 45ae0e9fb7
commit 765c3b85a5
4 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/features.txt
View file

@ -461,14 +461,14 @@ Vulkan 1.2 -- all DONE: anv
VK_KHR_shader_float16_int8 DONE (anv/gen8+, radv, tu)
VK_KHR_shader_float_controls DONE (anv/gen8+, radv, tu)
VK_KHR_shader_subgroup_extended_types DONE (anv/gen8+, radv)
VK_KHR_spirv_1_4 DONE (anv, radv)
VK_KHR_spirv_1_4 DONE (anv, radv, tu)
VK_KHR_timeline_semaphore DONE (anv, radv)
VK_KHR_uniform_buffer_standard_layout DONE (anv, lvp, radv)
VK_KHR_vulkan_memory_model DONE (anv, radv)
VK_EXT_descriptor_indexing DONE (anv/gen9+, radv, tu)
VK_EXT_host_query_reset DONE (anv, lvp, radv, tu)
VK_EXT_sampler_filter_minmax DONE (anv/gen9+, lvp, radv, tu)
VK_EXT_scalar_block_layout DONE (anv, lvp, radv/gfx7+)
VK_EXT_scalar_block_layout DONE (anv, lvp, radv/gfx7+, tu)
VK_EXT_separate_stencil_usage DONE (anv)
VK_EXT_shader_viewport_index_layer DONE (anv, lvp, radv, tu)

1
src/freedreno/ci/deqp-freedreno-a630-fails.txt
View file

@ -183,6 +183,7 @@ dEQP-VK.spirv_assembly.instruction.graphics.opquantize.too_small_geom,Fail
dEQP-VK.spirv_assembly.instruction.graphics.opquantize.too_small_tessc,Fail
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_single_buffer_geom,Fail
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_two_buffers_geom,Fail
dEQP-VK.spirv_assembly.instruction.spirv1p4.opcopylogical.nested_arrays_different_inner_stride,Fail
dEQP-VK.subgroups.basic.compute.subgroupelect,Crash
dEQP-VK.subgroups.basic.compute.subgroupmemorybarrier,Crash
dEQP-VK.subgroups.basic.compute.subgroupmemorybarriershared,Crash

8
src/freedreno/vulkan/tu_device.c
View file

@ -444,7 +444,7 @@ tu_GetPhysicalDeviceFeatures2(VkPhysicalDevice physicalDevice,
features->runtimeDescriptorArray = true;
features->samplerFilterMinmax = true;
features->scalarBlockLayout = false;
features->scalarBlockLayout = true;
features->imagelessFramebuffer = false;
features->uniformBufferStandardLayout = false;
features->shaderSubgroupExtendedTypes = false;
@ -610,6 +610,12 @@ tu_GetPhysicalDeviceFeatures2(VkPhysicalDevice physicalDevice,
features->shaderInt8 = false;
break;
}
case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES_EXT: {
VkPhysicalDeviceScalarBlockLayoutFeaturesEXT *features = (void *)ext;
features->scalarBlockLayout = true;
break;
}
default:
break;
}

2
src/freedreno/vulkan/tu_extensions.py
View file

@ -113,6 +113,8 @@ EXTENSIONS = [
Extension('VK_KHR_shader_float_controls', 1, True),
Extension('VK_KHR_shader_float16_int8', 1, True),
Extension('VK_KHR_16bit_storage', 1, 'device->gpu_id >= 650'),
Extension('VK_EXT_scalar_block_layout', 1, True),
Extension('VK_KHR_spirv_1_4', 1, True),
]
MAX_API_VERSION = VkVersion(MAX_API_VERSION)