From 7637fba4525b64d2ae0802004afabdef4fb9ef5f Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sun, 28 May 2023 20:20:09 -0700 Subject: [PATCH] freedreno/a6xx: Fix memory leak on error path. Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable fd6_ctx going out of scope leaks the storage it points to. Fixes: de3b34df973 ("freedreno: Add a6xx backend") Signed-off-by: Vinson Lee Reviewed-by: Rob Clark Part-of: --- src/gallium/drivers/freedreno/a6xx/fd6_context.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/a6xx/fd6_context.cc b/src/gallium/drivers/freedreno/a6xx/fd6_context.cc index 0493b6fcd23..2f404c67ac4 100644 --- a/src/gallium/drivers/freedreno/a6xx/fd6_context.cc +++ b/src/gallium/drivers/freedreno/a6xx/fd6_context.cc @@ -264,8 +264,10 @@ fd6_context_create(struct pipe_screen *pscreen, void *priv, setup_state_map(&fd6_ctx->base); pctx = fd_context_init(&fd6_ctx->base, pscreen, priv, flags); - if (!pctx) + if (!pctx) { + free(fd6_ctx); return NULL; + } pctx->set_framebuffer_state = fd6_set_framebuffer_state;