From 75eee7f38b9c5b8024b7938f7590091fa10f6b03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Pi=C3=B1eiro?= Date: Wed, 22 Oct 2025 12:01:23 +0200 Subject: [PATCH] panfrost: cleanup outputs_read/outputs_written at pan_shader_info With this commit we do two things: * Remove pan_shader_info.fs.outputs_written because it is not used, as there is already pan_shader_info.outputs_written * For pan_shader_info.fs.outputs_read we direcly copy the nir info.outputs_read, without a shift, for consistency and also because it is not really required. Reviewed-by: Lars-Ivar Hesselberg Simonsen Part-of: --- src/panfrost/lib/pan_shader.c | 4 ++-- src/panfrost/util/pan_ir.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/panfrost/lib/pan_shader.c b/src/panfrost/lib/pan_shader.c index 2832df8deae..b516a720d98 100644 --- a/src/panfrost/lib/pan_shader.c +++ b/src/panfrost/lib/pan_shader.c @@ -113,8 +113,8 @@ pan_shader_compile(nir_shader *s, struct pan_compile_inputs *inputs, if (s->info.outputs_written & BITFIELD64_BIT(FRAG_RESULT_SAMPLE_MASK)) info->fs.writes_coverage = true; - info->fs.outputs_read = s->info.outputs_read >> FRAG_RESULT_DATA0; - info->fs.outputs_written = s->info.outputs_written >> FRAG_RESULT_DATA0; + info->fs.outputs_read = s->info.outputs_read; + info->fs.sample_shading = s->info.fs.uses_sample_shading; info->fs.untyped_color_outputs = s->info.fs.untyped_color_outputs; diff --git a/src/panfrost/util/pan_ir.h b/src/panfrost/util/pan_ir.h index 243b448e7c6..e131547a5c6 100644 --- a/src/panfrost/util/pan_ir.h +++ b/src/panfrost/util/pan_ir.h @@ -233,7 +233,6 @@ struct pan_shader_info { bool can_early_z, can_fpk; bool untyped_color_outputs; BITSET_WORD outputs_read; - BITSET_WORD outputs_written; } fs; struct {