From 7544aae77cae8eee7d86574645bf508b3f99e8f1 Mon Sep 17 00:00:00 2001
From: Eric Engestrom <eric@igalia.com>
Date: Tue, 15 Jul 2025 20:55:54 +0200
Subject: [PATCH] ci: fix priority of nightly pipeline & staging pipeline jobs

The workflow rules added in 7bfb51a7e6 catch the `if` ladder too early and
bypass the `is-scheduled-pipeline`, `is-push-to-upstream-default-branch`,
and `is-push-to-upstream-staging-branch` rules setting the correct job
priority.

Fixes: 7bfb51a7e6f410cd670f ("ci: Fix missing pipelines on user pipelines in MRs")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35501>
---
 .gitlab-ci.yml | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9a309b791c8..46c7d807b8e 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -55,11 +55,6 @@ workflow:
     - if: &is-merge-request $CI_PIPELINE_SOURCE == "merge_request_event"
     # Push to a branch on a fork
     - if: &is-push-to-fork $CI_PROJECT_NAMESPACE != "mesa" && $CI_PIPELINE_SOURCE == "push"
-    # a pipeline running within the upstream project
-    - if: &is-upstream-pipeline $CI_PROJECT_PATH == $FDO_UPSTREAM_REPO
-    # an MR pipeline running within the upstream project, usually true for
-    # those with the Developer role or above
-    - if: &is-upstream-mr-pipeline $CI_PROJECT_PATH == $FDO_UPSTREAM_REPO && $CI_PIPELINE_SOURCE == "merge_request_event"
     # Nightly pipeline
     - if: &is-scheduled-pipeline $CI_PIPELINE_SOURCE == "schedule"
       variables:
@@ -265,7 +260,7 @@ include:
       when: manual
     # ... if the MR pipeline runs as mesa/mesa and does not need a container
     # rebuild, we can skip it
-    - if: *is-upstream-mr-pipeline
+    - if: &is-upstream-mr-pipeline $CI_PROJECT_PATH == $FDO_UPSTREAM_REPO && $CI_PIPELINE_SOURCE == "merge_request_event"
       when: never
     # ... however for MRs running inside the user namespace, we may need to
     # run these jobs to copy the container images from upstream
@@ -281,7 +276,7 @@ include:
     - if: *is-scheduled-pipeline
       when: never
     # Any other pipeline in the upstream should reuse already-built containers
-    - if: *is-upstream-pipeline
+    - if: &is-upstream-pipeline $CI_PROJECT_PATH == $FDO_UPSTREAM_REPO
       when: never
     # Allow building everything in fork pipelines, but build nothing unless
     # manually triggered