From 751e0d26ec66889b9ea0932f21e77b668e6d32f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ADra=20Canal?= Date: Sun, 22 Mar 2026 16:50:04 -0300 Subject: [PATCH] v3d: use the state uploader for the image view texture shader state MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From the documentation, the state uploader should be used inside the driver for long-term state inside buffers, while the stream uploader should be used by Gallium's internals. Considering that the image view texture shader state can be considered long-lived state data, use `state_uploader` instead of `uploader` for consistency. Reviewed-by: Iago Toral Quiroga Signed-off-by: Maíra Canal Part-of: --- src/gallium/drivers/v3d/v3dx_state.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/v3d/v3dx_state.c b/src/gallium/drivers/v3d/v3dx_state.c index b9b75a5ed22..a3eb0728c1f 100644 --- a/src/gallium/drivers/v3d/v3dx_state.c +++ b/src/gallium/drivers/v3d/v3dx_state.c @@ -1365,11 +1365,9 @@ v3d_create_image_view_texture_shader_state(struct v3d_context *v3d, struct v3d_image_view *iview = &so->si[img]; void *map; - u_upload_alloc_ref(v3d->uploader, 0, cl_packet_length(TEXTURE_SHADER_STATE), - 32, - &iview->tex_state_offset, - &iview->tex_state, - &map); + u_upload_alloc_ref(v3d->state_uploader, 0, + cl_packet_length(TEXTURE_SHADER_STATE), 32, + &iview->tex_state_offset, &iview->tex_state, &map); struct pipe_resource *prsc = iview->base.resource;