From 72923ee62f6ac26f5e657ac2e980962bc3d102dd Mon Sep 17 00:00:00 2001 From: Karmjit Mahil Date: Fri, 13 Oct 2023 17:10:00 +0100 Subject: [PATCH] pvr: Remove shareds_dest_offset from load_op The starting offset is always `0` and there isn't really a reason for why it should be non-zero, we always want to DMA into the shareds from the beginning, for the load_ops, so removing it. Signed-off-by: Karmjit Mahil Acked-by: Erik Faye-Lund Part-of: --- src/imagination/vulkan/pvr_cmd_buffer.c | 1 - src/imagination/vulkan/pvr_private.h | 1 - src/imagination/vulkan/pvr_usc.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/imagination/vulkan/pvr_cmd_buffer.c b/src/imagination/vulkan/pvr_cmd_buffer.c index 1a026311450..d9ec7f327af 100644 --- a/src/imagination/vulkan/pvr_cmd_buffer.c +++ b/src/imagination/vulkan/pvr_cmd_buffer.c @@ -824,7 +824,6 @@ static VkResult pvr_load_op_pds_data_create_and_upload( PDSINST_DOUT_FIELDS_DOUTD_SRC1, value) { value.dest = ROGUE_PDSINST_DOUTD_DEST_COMMON_STORE; - value.a0 = load_op->shareds_dest_offset; value.bsize = load_op->shareds_count; } diff --git a/src/imagination/vulkan/pvr_private.h b/src/imagination/vulkan/pvr_private.h index 3e1b1de169e..1a5d93d32ce 100644 --- a/src/imagination/vulkan/pvr_private.h +++ b/src/imagination/vulkan/pvr_private.h @@ -1116,7 +1116,6 @@ struct pvr_load_op { struct pvr_suballoc_bo *usc_frag_prog_bo; uint32_t const_shareds_count; - uint32_t shareds_dest_offset; uint32_t shareds_count; struct pvr_pds_upload pds_frag_prog; diff --git a/src/imagination/vulkan/pvr_usc.c b/src/imagination/vulkan/pvr_usc.c index afe7f83220e..ea1e51a2b01 100644 --- a/src/imagination/vulkan/pvr_usc.c +++ b/src/imagination/vulkan/pvr_usc.c @@ -1163,7 +1163,6 @@ pco_shader *pvr_uscgen_loadop(pco_ctx *ctx, struct pvr_load_op *load_op) load_op->const_shareds_count = shared_regs; load_op->shareds_count = shared_regs; - load_op->shareds_dest_offset = 0; return build_shader(ctx, b.shader, &data); }