From 7278f900394e7d8124075557a8008f14bebff20e Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Mon, 26 Oct 2020 19:55:07 -0700 Subject: [PATCH] gallium: Remove duplicate resource variable. Fix defect reported by Coverity Scan. Evaluation order violation (EVALUATION_ORDER) write_write_typo: In resource = resource = ntt_ureg_src_indirect(c, ureg_src_register(TGSI_FILE_IMAGE, 0U), instr->src[0]), resource is written twice with the same value. Fixes: 34cc6a804ec9 ("gallium: Add a nir-to-TGSI pass.") Signed-off-by: Vinson Lee Reviewed-by: Eric Anholt Part-of: --- src/gallium/auxiliary/nir/nir_to_tgsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/nir/nir_to_tgsi.c b/src/gallium/auxiliary/nir/nir_to_tgsi.c index 231192792c1..d74eafd06a3 100644 --- a/src/gallium/auxiliary/nir/nir_to_tgsi.c +++ b/src/gallium/auxiliary/nir/nir_to_tgsi.c @@ -1222,8 +1222,8 @@ ntt_emit_image_load_store(struct ntt_compile *c, nir_intrinsic_instr *instr) nir_intrinsic_image_array(instr)); struct ureg_src resource = - resource = ntt_ureg_src_indirect(c, ureg_src_register(TGSI_FILE_IMAGE, 0), - instr->src[0]); + ntt_ureg_src_indirect(c, ureg_src_register(TGSI_FILE_IMAGE, 0), + instr->src[0]); struct ureg_dst dst; if (instr->intrinsic == nir_intrinsic_image_store) {