fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-14 14:28:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

pvr: Add comments documenting large/normal clear words.

Browse source 
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20055>
This commit is contained in:
Karmjit Mahil 2022-10-05 10:35:42 +01:00 • committed by Marge Bot
parent a308d38fae
commit 72151aa426
2 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/imagination/vulkan/pvr_clear.c
View file

@ -337,7 +337,15 @@ VkResult pvr_device_init_graphics_static_clear_state(struct pvr_device *device)
* dedup this? * dedup this?
*/ */
/* TODO: Figure out where the 4 * sizeof(uint32_t) comes from. */ /* The large clear state words cover the max framebuffer. The normal clear
* state words cover only half (since 3 indices are passed, forming a single
* triangle, instead of 4) and are used when the render area fits within a
* quarter of the max framebuffer, i.e. fit within the single triangle.
*/
/* 4 * sizeof(uint32_t) because of the 4 pixel output regs. */
/* TODO: Replace 4 * sizeof(uint32_t) with a defines from the compiler or
* hook up the value directly to it using some compiler info.
*/
pvr_pack_clear_vdm_state(&device->pdevice->dev_info, pvr_pack_clear_vdm_state(&device->pdevice->dev_info,
&state->pds, &state->pds,
pds_program.temps_used, pds_program.temps_used,
@ -346,7 +354,6 @@ VkResult pvr_device_init_graphics_static_clear_state(struct pvr_device *device)
1, 1,
state->vdm_words); state->vdm_words);
/* TODO: Figure out where the 4 * sizeof(uint32_t) comes from. */
pvr_pack_clear_vdm_state(&device->pdevice->dev_info, pvr_pack_clear_vdm_state(&device->pdevice->dev_info,
&state->pds, &state->pds,
pds_program.temps_used, pds_program.temps_used,

14
src/imagination/vulkan/pvr_cmd_buffer.c
View file

@ -2363,6 +2363,20 @@ pvr_cmd_buffer_set_clear_values(struct pvr_cmd_buffer *cmd_buffer,
return VK_SUCCESS; return VK_SUCCESS;
} }
/**
* \brief Indicates whether to use the large or normal clear state words.
*
* If the current render area can fit within a quarter of the max framebuffer
* that the device is capable of, we can use the normal clear state words,
* otherwise the large clear state words are needed.
*
* The requirement of a quarter of the max framebuffer comes from the index
* count used in the normal clear state words and the vertices uploaded at
* device creation.
*
* \param[in] cmd_buffer The command buffer for the clear.
* \return true if large clear state words are required.
*/
static bool static bool
pvr_is_large_clear_required(const struct pvr_cmd_buffer *const cmd_buffer) pvr_is_large_clear_required(const struct pvr_cmd_buffer *const cmd_buffer)
{ {