fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/bi: Move opt_sink and opt_move calls to postprocess

Browse source 
The comments pretty explicitly say that they assume lowered UBOs and
SSBOs so preprocess is the wrong place for them.

Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
Acked-by: Eric R. Smith <eric.smith@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38821>
This commit is contained in:
Faith Ekstrand 2025-12-05 11:16:28 -05:00 • committed by Marge Bot
parent 5841106027
commit 7206572884
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/panfrost/compiler/bifrost/bifrost_compile.c
View file

@ -6252,6 +6252,12 @@ bifrost_preprocess_nir(nir_shader *nir, unsigned gpu_id)
/* Lower away all variables for smaller shaders */
NIR_PASS(_, nir, nir_lower_vars_to_ssa);
NIR_PASS(_, nir, nir_remove_dead_variables, nir_var_function_temp, NULL);
}
void
bifrost_postprocess_nir(nir_shader *nir, unsigned gpu_id)
{
MESA_TRACE_FUNC();
/* We assume that UBO and SSBO were lowered, let's move things around. */
nir_move_options move_all = nir_move_const_undef | nir_move_load_ubo |
@ -6260,12 +6266,6 @@ bifrost_preprocess_nir(nir_shader *nir, unsigned gpu_id)
NIR_PASS(_, nir, nir_opt_sink, move_all);
NIR_PASS(_, nir, nir_opt_move, move_all);
}
void
bifrost_postprocess_nir(nir_shader *nir, unsigned gpu_id)
{
MESA_TRACE_FUNC();
bifrost_lower_texture_nir(nir, gpu_id);