From 718236ebb8f90eda2e08da0b8a9dfbd193040bff Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 6 Jun 2026 20:27:29 -0700 Subject: [PATCH] ethosu: use FALLTHROUGH macro in ethosu_emit_operation_accesses Compiling with clang produces a -Wimplicit-fallthrough warning: src/gallium/drivers/ethosu/ethosu_cmd.c:1032:7: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] The plain "/* fall-through */" comment is not recognized by clang as a fall-through annotation, so the intentional fall-through from the ETHOSU_OPERATION_TYPE_CONVOLUTION case into the default case is flagged. Replace the comment with the FALLTHROUGH macro, which expands to the appropriate attribute and documents the intent for both GCC and clang. Fixes: dce4b0313a24 ("ethosu: Add reshape operation") Assisted-by: Claude Code (Claude Opus 4.8) Signed-off-by: Vinson Lee Part-of: --- src/gallium/drivers/ethosu/ethosu_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ethosu/ethosu_cmd.c b/src/gallium/drivers/ethosu/ethosu_cmd.c index d00076d33b1..ef30146e358 100644 --- a/src/gallium/drivers/ethosu/ethosu_cmd.c +++ b/src/gallium/drivers/ethosu/ethosu_cmd.c @@ -1028,7 +1028,7 @@ fill_memory_accesses(struct ethosu_subgraph *subgraph) operation->read_accesses[3].region = operation->conv.weights.region; operation->read_accesses[3].address = operation->conv.weights.address; operation->read_accesses[3].size = operation->conv.weights.size; - /* fall-through */ + FALLTHROUGH; default: operation->read_accesses[0].region = IO_REGION; operation->read_accesses[0].address = operation->ifm.tiles.addresses[0];