fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 00:38:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panvk: assert on missing vs

Browse source 
A vs is always required, and we already dereference it in this function
unconditionally. Let's add an assert to be sure, and drop the run-time
check here.

CID: 1620449
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31767>
This commit is contained in:
Erik Faye-Lund 2024-10-16 12:26:54 +02:00 • committed by Marge Bot
parent 9ad9d9ac68
commit 712c11fc17
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c
View file

@ -1359,6 +1359,8 @@ prepare_draw(struct panvk_cmd_buffer *cmdbuf, struct panvk_draw_info *draw)
bool idvs = vs->info.vs.idvs;
VkResult result;
assert(vs);
/* FIXME: support non-IDVS. */
assert(idvs);
@ -1414,7 +1416,7 @@ prepare_draw(struct panvk_cmd_buffer *cmdbuf, struct panvk_draw_info *draw)
uint32_t varying_size = 0;
if (vs && fs) {
if (fs) {
unsigned vs_vars = vs->info.varyings.output_count;
unsigned fs_vars = fs->info.varyings.input_count;
unsigned var_slots = MAX2(vs_vars, fs_vars);