fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nak: use fmul_rtz for NAK_INTERP_MODE_PERSPECTIVE

Browse source 
Fixes rendering artifacts in The Surge 2 and Shadow of the Tomb Raider.
And it's what nvidia's driver is doing.

Totals from 170446 (14.05% of 1212873) affected shaders:
CodeSize: 2019019440 -> 2026071952 (+0.35%); split: -0.07%, +0.41%
Number of GPRs: 8158110 -> 8098382 (-0.73%); split: -0.80%, +0.07%
SLM Size: 106448 -> 106440 (-0.01%)
Static cycle count: 1398452243 -> 1400038117 (+0.11%); split: -0.17%, +0.28%
Spills to memory: 546 -> 520 (-4.76%)
Fills from memory: 546 -> 520 (-4.76%)
Spills to reg: 22585 -> 22670 (+0.38%); split: -0.31%, +0.68%
Fills from reg: 18243 -> 18331 (+0.48%); split: -0.34%, +0.82%
Max warps/SM: 6797472 -> 6822196 (+0.36%); split: +0.38%, -0.02%

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/work_items/11447
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/work_items/11706
Backport-to: 26.1
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41179>
(cherry picked from commit f5e92e5493)
This commit is contained in:
Karol Herbst 2026-04-25 14:39:07 +02:00 • committed by Eric Engestrom
parent a47adc8740
commit 6ffe6d4363
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2564,7 +2564,7 @@
"description": "nak: use fmul_rtz for NAK_INTERP_MODE_PERSPECTIVE",
"nominated": true,
"nomination_type": 4,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

11
src/nouveau/compiler/nak_nir_lower_fs_inputs.c
View file

@ -67,8 +67,15 @@ interp_fs_input(nir_builder *b, unsigned num_components, uint32_t addr,
comps[c] = nir_ipa_nv(b, nir_imm_float(b, 0), offset,
.base = addr + c * 4,
.flags = NAK_AS_U32(flags));
if (interp_mode == NAK_INTERP_MODE_PERSPECTIVE)
comps[c] = nir_fmul(b, comps[c], inv_w);
if (interp_mode == NAK_INTERP_MODE_PERSPECTIVE) {
unsigned fp_math_ctrl = b->fp_math_ctrl;
b->fp_math_ctrl |= nir_fp_exact;
/* It seems critical that this is done as round to zero.
* The Surge 2 and Shadow of the Tomb Raider show artifacts if not.
*/
comps[c] = nir_fmul_rtz(b, comps[c], inv_w);
b->fp_math_ctrl = fp_math_ctrl;
}
}
return nir_vec(b, comps, num_components);
} else if (nak->sm >= 20) {