mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-05 16:08:04 +02:00
i965: Clamp texture buffer size to GL_MAX_TEXTURE_BUFFER_SIZE.
The OpenGL 4.5 specification's description of TexBuffer says: "The number of texels in the texture image is then clamped to an implementation-dependent limit, the value of MAX_TEXTURE_BUFFER_SIZE." We set GL_MAX_TEXTURE_BUFFER_SIZE to 2^27. For buffers with a byte element size, this is the maximum possible size we can encode in SURFACE_STATE. If you bind a buffer object larger than this as a texture buffer object, we'll exceed that limit and hit an isl assert: assert(num_elements <= (1ull << 27)); To fix this, clamp the size in bytes to MaxTextureSize / texel_size. Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
This commit is contained in:
parent
eaf4a106bd
commit
6f71d9adc1
1 changed files with 18 additions and 0 deletions
|
|
@ -695,6 +695,24 @@ brw_update_buffer_texture_surface(struct gl_context *ctx,
|
|||
bo = intel_bufferobj_buffer(brw, intel_obj, tObj->BufferOffset, size);
|
||||
}
|
||||
|
||||
/* The ARB_texture_buffer_specification says:
|
||||
*
|
||||
* "The number of texels in the buffer texture's texel array is given by
|
||||
*
|
||||
* floor(<buffer_size> / (<components> * sizeof(<base_type>)),
|
||||
*
|
||||
* where <buffer_size> is the size of the buffer object, in basic
|
||||
* machine units and <components> and <base_type> are the element count
|
||||
* and base data type for elements, as specified in Table X.1. The
|
||||
* number of texels in the texel array is then clamped to the
|
||||
* implementation-dependent limit MAX_TEXTURE_BUFFER_SIZE_ARB."
|
||||
*
|
||||
* We need to clamp the size in bytes to MAX_TEXTURE_BUFFER_SIZE * stride,
|
||||
* so that when ISL divides by stride to obtain the number of texels, that
|
||||
* texel count is clamped to MAX_TEXTURE_BUFFER_SIZE.
|
||||
*/
|
||||
size = MIN2(size, ctx->Const.MaxTextureBufferSize * (unsigned) texel_size);
|
||||
|
||||
if (brw_format == 0 && format != MESA_FORMAT_RGBA_FLOAT32) {
|
||||
_mesa_problem(NULL, "bad format %s for texture buffer\n",
|
||||
_mesa_get_format_name(format));
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue