From 6f6be1368aa4d87e60e00aa37bbbd95c6b0278e3 Mon Sep 17 00:00:00 2001 From: Marc Alcala Prieto Date: Wed, 8 Apr 2026 10:47:24 +0200 Subject: [PATCH] pan/cs: Fix cs_run_fragment() calls with swapped arguments Fix non-functional issue where calls to cs_run_fragment() had swapped tile_order and enable_tem arguments. Both arguments evaluate to 0. Hence, no functional change. Fixes: 53f780ec916 ("panfrost: Remove progress_increment from all CS builders") Reviewed-by: Lars-Ivar Hesselberg Simonsen Reviewed-by: Christian Gmeiner (cherry picked from commit 0d08b197f2f66b2cf080e8332f46387eb99e5d55) Part-of: --- .pick_status.json | 2 +- src/gallium/drivers/panfrost/pan_csf.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index bcc90e6a96e..ee2192f2c10 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -3054,7 +3054,7 @@ "description": "pan/cs: Fix cs_run_fragment() calls with swapped arguments", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "53f780ec916d1cd4773af6cec40c3149042d852f", "notes": null diff --git a/src/gallium/drivers/panfrost/pan_csf.c b/src/gallium/drivers/panfrost/pan_csf.c index d19c2339d40..474d39c129d 100644 --- a/src/gallium/drivers/panfrost/pan_csf.c +++ b/src/gallium/drivers/panfrost/pan_csf.c @@ -150,7 +150,7 @@ csf_oom_handler_init(struct panfrost_context *ctx) /* Run the fragment job and wait */ cs_select_endpoint_sb(&b, 3); - cs_run_fragment(&b, MALI_TILE_RENDER_ORDER_Z_ORDER, false); + cs_run_fragment(&b, false, MALI_TILE_RENDER_ORDER_Z_ORDER); cs_wait_slot(&b, 3); /* Increment counter */ @@ -864,7 +864,7 @@ GENX(csf_emit_fragment_job)(struct panfrost_batch *batch, } /* Run the fragment job and wait */ - cs_run_fragment(b, MALI_TILE_RENDER_ORDER_Z_ORDER, false); + cs_run_fragment(b, false, MALI_TILE_RENDER_ORDER_Z_ORDER); cs_wait_slot(b, 2); /* Gather freed heap chunks and add them to the heap context free list