fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 13:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/cs: Fix cs_run_fragment() calls with swapped arguments

Browse source 
Fix non-functional issue where calls to cs_run_fragment() had swapped
tile_order and enable_tem arguments. Both arguments evaluate to 0.
Hence, no functional change.

Fixes: 53f780ec91 ("panfrost: Remove progress_increment from all CS builders")
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
(cherry picked from commit 0d08b197f2)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40979>
This commit is contained in:
Marc Alcala Prieto 2026-04-08 10:47:24 +02:00 • committed by Eric Engestrom
parent 5447f81cc5
commit 6f6be1368a
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3054,7 +3054,7 @@
"description": "pan/cs: Fix cs_run_fragment() calls with swapped arguments",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "53f780ec916d1cd4773af6cec40c3149042d852f",
"notes": null

4
src/gallium/drivers/panfrost/pan_csf.c
View file

@ -150,7 +150,7 @@ csf_oom_handler_init(struct panfrost_context *ctx)
/* Run the fragment job and wait */
cs_select_endpoint_sb(&b, 3);
cs_run_fragment(&b, MALI_TILE_RENDER_ORDER_Z_ORDER, false);
cs_run_fragment(&b, false, MALI_TILE_RENDER_ORDER_Z_ORDER);
cs_wait_slot(&b, 3);
/* Increment counter */
@ -864,7 +864,7 @@ GENX(csf_emit_fragment_job)(struct panfrost_batch *batch,
}
/* Run the fragment job and wait */
cs_run_fragment(b, MALI_TILE_RENDER_ORDER_Z_ORDER, false);
cs_run_fragment(b, false, MALI_TILE_RENDER_ORDER_Z_ORDER);
cs_wait_slot(b, 2);
/* Gather freed heap chunks and add them to the heap context free list