From 6e8ec44287e6e370715633dfc3d1362459d7e71d Mon Sep 17 00:00:00 2001 From: Danylo Piliaiev Date: Thu, 16 Apr 2026 14:56:10 +0200 Subject: [PATCH] tu/u_trace: Correct the order of tracepoints clonning for binning Otherwise we'd get tracepoints out of logical order, which doesn't matter for perfetto at the moment, but would matter with future perf warnings. Signed-off-by: Danylo Piliaiev Part-of: --- src/freedreno/vulkan/tu_cmd_buffer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/freedreno/vulkan/tu_cmd_buffer.cc b/src/freedreno/vulkan/tu_cmd_buffer.cc index 2e85ee50be0..ff1766f4197 100644 --- a/src/freedreno/vulkan/tu_cmd_buffer.cc +++ b/src/freedreno/vulkan/tu_cmd_buffer.cc @@ -2706,13 +2706,13 @@ tu6_emit_binning_pass(struct tu_cmd_buffer *cmd, struct tu_cs *cs, /* emit IB to binning drawcmds: */ tu_cs_emit_call(cs, &cmd->draw_cs); + tu_clone_trace_range(cmd, cs, &cmd->trace, cmd->trace_renderpass_start, u_trace_end_iterator(&cmd->rp_trace)); + if (use_cb) trace_end_concurrent_binning_ib(&cmd->trace, cs); else trace_end_binning_ib(&cmd->trace, cs); - tu_clone_trace_range(cmd, cs, &cmd->trace, cmd->trace_renderpass_start, u_trace_end_iterator(&cmd->rp_trace)); - /* switching from binning pass to GMEM pass will cause a switch from * PROGRAM_BINNING to PROGRAM, which invalidates const state (XS_CONST states) * so make sure these states are re-emitted