From 6e0f9e8f67168cfc75f39772cb384c7cc54def11 Mon Sep 17 00:00:00 2001 From: Christian Gmeiner Date: Mon, 21 Jul 2025 21:43:40 +0200 Subject: [PATCH] etnaviv: Replace unsupported blit debug message with detailed dump and assertion Replace the basic debug message for unsupported blits with a comprehensive dump of the blit parameters and make it a hard failure. This helps identify exactly what blit operations are not supported and ensures they don't fail silently in debug builds. Signed-off-by: Christian Gmeiner Part-of: --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_clear_blit.c b/src/gallium/drivers/etnaviv/etnaviv_clear_blit.c index 791fb886fd0..09e5ae74c73 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_clear_blit.c +++ b/src/gallium/drivers/etnaviv/etnaviv_clear_blit.c @@ -41,6 +41,7 @@ #include "pipe/p_state.h" #include "util/compiler.h" #include "util/u_blitter.h" +#include "util/u_dump.h" #include "util/u_inlines.h" #include "util/u_memory.h" #include "util/u_surface.h" @@ -146,10 +147,10 @@ etna_blit(struct pipe_context *pctx, const struct pipe_blit_info *blit_info) } if (!util_blitter_is_blit_supported(ctx->blitter, &info)) { - DBG("blit unsupported %s -> %s", - util_format_short_name(info.src.resource->format), - util_format_short_name(info.dst.resource->format)); - return; + fprintf(stderr, "\n"); + util_dump_blit_info(stderr, &info); + fprintf(stderr, "\n\n"); + UNREACHABLE("Unsupported blit"); } etna_blit_save_state(ctx, info.render_condition_enable);