fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-26 15:00:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

zink: add ZINK_DEBUG=optimal_keys

Browse source 
it's otherwise very annoying to figure out why this may or may not be
available

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22854>
This commit is contained in:
Mike Blumenkrantz 2023-05-04 10:11:02 -04:00 • committed by Marge Bot
parent dcf3adbde7
commit 6d84b34359
3 changed files with 30 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/drivers/zink.rst
View file

@ -309,6 +309,8 @@ variable:
Force synchronous flushes/presents
``noshobj``
Disable EXT_shader_object
``optimal_keys``
Debug/use optimal_keys
Vulkan Validation Layers
^^^^^^^^^^^^^^^^^^^^^^^^

27
src/gallium/drivers/zink/zink_screen.c
View file

@ -93,6 +93,7 @@ zink_debug_options[] = {
{ "map", ZINK_DEBUG_MAP, "Track amount of mapped VRAM" },
{ "flushsync", ZINK_DEBUG_FLUSHSYNC, "Force synchronous flushes/presents" },
{ "noshobj", ZINK_DEBUG_NOSHOBJ, "Disable EXT_shader_object" },
{ "optimal_keys", ZINK_DEBUG_OPTIMAL_KEYS, "Debug/use optimal_keys" },
DEBUG_NAMED_VALUE_END
};
@ -2609,6 +2610,32 @@ init_optimal_keys(struct zink_screen *screen)
!screen->driver_workarounds.lower_robustImageAccess2 &&
!screen->driconf.emulate_point_smooth &&
!screen->driver_workarounds.needs_zs_shader_swizzle;
if (!screen->optimal_keys && zink_debug & ZINK_DEBUG_OPTIMAL_KEYS) {
fprintf(stderr, "The following criteria are preventing optimal_keys enablement:");
if (screen->need_decompose_attrs)
fprintf(stderr, "missing vertex attribute formats\n");
if (screen->driconf.inline_uniforms)
fprintf(stderr, "uniform inlining must be disabled (set ZINK_INLINE_UNIFORMS=0 in your env)\n");
CHECK_OR_PRINT(have_EXT_line_rasterization);
CHECK_OR_PRINT(line_rast_feats.stippledBresenhamLines);
CHECK_OR_PRINT(feats.features.geometryShader);
CHECK_OR_PRINT(feats.features.sampleRateShading);
CHECK_OR_PRINT(have_EXT_non_seamless_cube_map);
CHECK_OR_PRINT(have_EXT_provoking_vertex);
if (screen->driver_workarounds.no_linesmooth)
fprintf(stderr, "driver does not support smooth lines\n");
if (screen->driver_workarounds.no_hw_gl_point)
fprintf(stderr, "driver does not support hardware GL_POINT\n");
CHECK_OR_PRINT(rb2_feats.robustImageAccess2);
CHECK_OR_PRINT(feats.features.robustBufferAccess);
CHECK_OR_PRINT(rb_image_feats.robustImageAccess);
if (screen->driconf.emulate_point_smooth)
fprintf(stderr, "smooth point emulation is enabled\n");
if (screen->driver_workarounds.needs_zs_shader_swizzle)
fprintf(stderr, "Z/S shader swizzle workaround is enabled\n");
mesa_logw("zink: force-enabling optimal_keys despite missing features. Good luck!");
screen->optimal_keys = true;
}
if (!screen->optimal_keys)
screen->info.have_EXT_graphics_pipeline_library = false;

1
src/gallium/drivers/zink/zink_types.h
View file

@ -222,6 +222,7 @@ enum zink_debug {
ZINK_DEBUG_MAP = (1<<11),
ZINK_DEBUG_FLUSHSYNC = (1<<12),
ZINK_DEBUG_NOSHOBJ = (1<<13),
ZINK_DEBUG_OPTIMAL_KEYS = (1<<14),
};
enum zink_pv_emulation_primitive {