fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-06 11:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/isl: Disallow Yf, Ys and Tile64 for 3D depth/stencil surfaces

Browse source 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23620>
This commit is contained in:
Lionel Landwerlin 2018-10-12 12:17:02 -05:00 • committed by Marge Bot
parent 911832e9cf
commit 6cde6b1d1a
2 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/intel/isl/isl_gfx12.c
View file

@ -48,9 +48,21 @@ isl_gfx125_filter_tiling(const struct isl_device *dev,
ISL_TILING_4_BIT |
ISL_TILING_64_BIT;
if (isl_surf_usage_is_depth_or_stencil(info->usage))
if (isl_surf_usage_is_depth_or_stencil(info->usage)) {
*flags &= ISL_TILING_4_BIT | ISL_TILING_64_BIT;
/* We choose to avoid Tile64 for 3D depth/stencil buffers. The swizzle
* for Tile64 is dependent on the image dimension. So, reads and writes
* should specify the same dimension to consistently interpret the data.
* This is not possible for 3D depth/stencil buffers however. Such
* buffers can be sampled from with a 3D view, but rendering is only
* possible with a 2D view due to the limitations of
* 3DSTATE_(DEPTH|STENCIL)_BUFFER.
*/
if (info->dim == ISL_SURF_DIM_3D)
*flags &= ~ISL_TILING_64_BIT;
}
if (info->usage & ISL_SURF_USAGE_DISPLAY_BIT)
*flags &= ~ISL_TILING_64_BIT;

13
src/intel/isl/isl_gfx7.c
View file

@ -238,6 +238,19 @@ isl_gfx6_filter_tiling(const struct isl_device *dev,
*flags &= ISL_TILING_ANY_Y_MASK;
}
if (isl_surf_usage_is_depth_or_stencil(info->usage)) {
/* We choose to avoid Yf/Ys for 3D depth/stencil buffers. The swizzles
* for the Yf and Ys tilings are dependent on the image dimension. So,
* reads and writes should specify the same dimension to consistently
* interpret the data. This is not possible for 3D depth/stencil buffers
* however. Such buffers can be sampled from with a 3D view, but
* rendering is only possible with a 2D view due to the limitations of
* 3DSTATE_(DEPTH|STENCIL)_BUFFER.
*/
if (info->dim == ISL_SURF_DIM_3D)
*flags &= ~ISL_TILING_STD_Y_MASK;
}
if (isl_surf_usage_is_stencil(info->usage)) {
if (ISL_GFX_VER(dev) >= 12) {
/* Stencil requires Y. */