fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-10 01:40:14 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

hk: be robust against invalid MSAA inputs

Browse source 
fixes vkd3d-proton test_multisample_rendering

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32320>
This commit is contained in:
Alyssa Rosenzweig 2024-11-23 18:10:53 -05:00 • committed by Marge Bot
parent 1f7598c202
commit 6b8d4cca7e
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/asahi/vulkan/hk_cmd_draw.c
View file

@ -2968,12 +2968,16 @@ hk_flush_dynamic_state(struct hk_cmd_buffer *cmd, struct hk_cs *cs,
/* With attachmentless rendering, we don't know the sample count until draw
* time, so we do a late tilebuffer fix up. But with rasterizer discard,
* rasterization_samples might be 0.
*
* Note that we ignore dyn->ms.rasterization_samples when we do have a sample
* count from an attachment. In Vulkan, these have to match anyway, but DX12
* drivers are robust against this scenarios and vkd3d-proton will go out of
* spec here. No reason we can't be robust here too.
*/
if (dyn->ms.rasterization_samples &&
gfx->render.tilebuffer.nr_samples != dyn->ms.rasterization_samples) {
if (dyn->ms.rasterization_samples && !gfx->render.tilebuffer.nr_samples) {
agx_tilebuffer_set_samples(&gfx->render.tilebuffer,
dyn->ms.rasterization_samples);
unsigned nr_samples = MAX2(dyn->ms.rasterization_samples, 1);
agx_tilebuffer_set_samples(&gfx->render.tilebuffer, nr_samples);
cs->tib = gfx->render.tilebuffer;
}