From 6b4f2d85296d23a9db7666eece40bd8cd747272d Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 5 Jan 2021 19:21:26 -0500 Subject: [PATCH] pan/bi: Allow passing thorugh 8-bit scalars Needed for fragment output. Not nearly sufficient for actual 8-bit types in e.g OpenCL. Signed-off-by: Alyssa Rosenzweig Tested-by: Maciej Matuszczyk Part-of: --- src/panfrost/bifrost/bifrost_compile.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/panfrost/bifrost/bifrost_compile.c b/src/panfrost/bifrost/bifrost_compile.c index 589ead1e4d4..d29c9fc948b 100644 --- a/src/panfrost/bifrost/bifrost_compile.c +++ b/src/panfrost/bifrost/bifrost_compile.c @@ -726,7 +726,10 @@ bi_alu_src_index(nir_alu_src src, unsigned comps) unsigned c1 = (comps > 1) ? src.swizzle[1] & 1 : c0; idx.swizzle = BI_SWIZZLE_H00 + c1 + (c0 << 1); } else if (bitsize == 8) { - unreachable("8-bit handling todo"); + /* 8-bit vectors not yet supported */ + assert(comps == 1 && "8-bit vectors not supported"); + assert(src.swizzle[0] == 0 && "8-bit vectors not supported"); + idx.swizzle = BI_SWIZZLE_B0000; } return idx;