fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-22 04:28:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

radeonsi: fix a typo in si_shader_update_spi_shader_formats

Browse source 
The failure is reproducible with:
    AMD_DEBUG=mono piglit/bin/fbo-drawbuffers-none use_frag_out -auto -fbo

Fixes: 88986dcc9c - radeonsi: account for outputs_written when updating spi_shader_col_format

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
(cherry picked from commit 5e6952307d)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41540>
This commit is contained in:
Marek Olšák 2026-04-25 23:00:09 -04:00 • committed by Eric Engestrom
parent eced50db84
commit 6b27a4a393
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -644,7 +644,7 @@
"description": "radeonsi: fix a typo in si_shader_update_spi_shader_formats",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "88986dcc9c81342a26951d576924d00a21d812c7",
"notes": null

2
src/gallium/drivers/radeonsi/si_shader_variant_info.c
View file

@ -38,7 +38,7 @@ void si_shader_update_spi_shader_formats(struct si_shader *shader, nir_shader *n
for (i = 0; i < num_targets; i++) {
unsigned spi_format = (spi_shader_col_format >> (i * 4)) & 0xf;
if (spi_format && (colors_written & 1u << num_mrts)) {
if (spi_format && (colors_written & 1u << i)) {
value |= spi_format << (num_mrts * 4);
num_mrts++;
}