fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 20:38:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panfrost: Fix bifrost tiler descriptor definition

Browse source 
The bifrost tiler descriptor definition was wrong, leading to a buffer
overflow.

Fixes: efce73d99d ("panfrost: XML-ify the bifrost tiler descriptors")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Christian Hewitt <christianshewitt@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6859>
This commit is contained in:
Boris Brezillon 2020-09-25 10:24:43 +02:00
parent 4017116fa0
commit 6abb4cd8b9
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/panfrost/lib/midgard.xml
View file

@ -1010,11 +1010,18 @@
<field name="Top" size="64" start="6:0" type="address"/>
</struct>
<struct name="Bifrost Tiler Weights" size="1">
<field name="Value" size="16" start="0:16" type="uint"/>
<struct name="Bifrost Tiler Weights" size="8">
<field name="Weight0" size="16" start="0:16" type="uint"/>
<field name="Weight1" size="16" start="1:16" type="uint"/>
<field name="Weight2" size="16" start="2:16" type="uint"/>
<field name="Weight3" size="16" start="3:16" type="uint"/>
<field name="Weight4" size="16" start="4:16" type="uint"/>
<field name="Weight5" size="16" start="5:16" type="uint"/>
<field name="Weight6" size="16" start="6:16" type="uint"/>
<field name="Weight7" size="16" start="7:16" type="uint"/>
</struct>
<struct name="Bifrost Tiler">
<struct name="Bifrost Tiler" size="48">
<field name="Polygon List" size="64" start="0:0" type="address"/>
<field name="Hierarchy Mask" size="13" start="2:0" type="uint"/>
<field name="Sample Pattern" size="3" start="2:13" type="Sample Pattern"/>
@ -1022,7 +1029,7 @@
<field name="FB Width" size="16" start="3:0" type="uint" modifier="minus(1)"/>
<field name="FB Height" size="16" start="3:16" type="uint" modifier="minus(1)"/>
<field name="Heap" size="64" start="6:0" type="address"/>
<field name="Weights" size="32" start="8:0" type="Bifrost Tiler Weights" elements="8"/>
<field name="Weights" size="256" start="8:0" type="Bifrost Tiler Weights"/>
</struct>
<struct name="Bifrost Tiler Pointer">