From 69becc0509c31b95f65edebd4f4d830a91e1ca8d Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 4 Oct 2025 22:18:53 -0700 Subject: [PATCH] panfrost: Remove duplicate variable ret Fix defect reported by Coverity Scan. Evaluation order violation (EVALUATION_ORDER) write_write_typo: In ret = ret = ({...; drmIoctl(panfrost_device_fd(dev), 3221775434UL, &args);}), ret is written twice with the same value. Fixes: e9aedfe50857 ("panfrost: Support JM context creation and destruction") Signed-off-by: Vinson Lee Reviewed-by: Erik Faye-Lund Reviewed-by: Boris Brezillon Part-of: --- src/gallium/drivers/panfrost/pan_jm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_jm.c b/src/gallium/drivers/panfrost/pan_jm.c index 64c53823288..cb75d0dfbb5 100644 --- a/src/gallium/drivers/panfrost/pan_jm.c +++ b/src/gallium/drivers/panfrost/pan_jm.c @@ -1057,9 +1057,9 @@ GENX(jm_init_context)(struct panfrost_context *ctx) .priority = prio, }; - int ret = ret = pan_kmod_ioctl(panfrost_device_fd(dev), - DRM_IOCTL_PANFROST_JM_CTX_CREATE, - &args); + int ret = pan_kmod_ioctl(panfrost_device_fd(dev), + DRM_IOCTL_PANFROST_JM_CTX_CREATE, + &args); if (ret) return -1;