fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 16:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: fix transaction elimination crc valid calculation

Browse source 
The setting of the clean_pixel_write_enable flag in pan_prepare_rt
was not consistent with the crc valid calculations in pan_emit_fbd.
This caused the crc_valid flag to not be accurate, causing transaction
elimination to fail.

Fixes: eac8f1d460 ("Revert "panfrost: Disable CRC by default"")
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34408>
This commit is contained in:
Eric R. Smith 2025-04-07 10:03:56 -03:00 • committed by Marge Bot
parent c4b305079d
commit 69a6db4b2b
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/panfrost/lib/pan_desc.c
View file

@ -537,12 +537,25 @@ pan_rt_init_format(const struct pan_image_view *rt,
cfg->swizzle = panfrost_translate_swizzle_4(swizzle);
}
/* forward declaration */
static bool pan_force_clean_write_on(const struct pan_image *img, unsigned tile_size);
static void
pan_prepare_rt(const struct pan_fb_info *fb, unsigned layer_idx,
unsigned rt_idx, unsigned cbuf_offset,
struct MALI_RENDER_TARGET *cfg)
{
#if PAN_ARCH >= 6
bool force_clean_writes = fb->rts[rt_idx].clear;
if (fb->rts[rt_idx].view) {
const struct pan_image *img =
pan_image_view_get_color_plane(fb->rts[rt_idx].view);
force_clean_writes |= pan_force_clean_write_on(img, fb->tile_size);
}
cfg->clean_pixel_write_enable = force_clean_writes;
#else
cfg->clean_pixel_write_enable = fb->rts[rt_idx].clear;
#endif
cfg->internal_buffer_offset = cbuf_offset;
if (fb->rts[rt_idx].clear) {
cfg->clear.color_0 = fb->rts[rt_idx].clear_value[0];