fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-24 14:40:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

asahi: fix rgb565 blending

Browse source 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29179>
This commit is contained in:
Alyssa Rosenzweig 2024-04-19 22:06:27 -04:00 • committed by Marge Bot
parent 292cd87054
commit 696f4654d4
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/asahi/lib/agx_nir_lower_tilebuffer.c
View file

@ -90,6 +90,24 @@ store_tilebuffer(nir_builder *b, struct agx_tilebuffer_layout *tib,
.format = format);
}
static nir_def *
nir_fsat_signed(nir_builder *b, nir_def *x)
{
return nir_fclamp(b, x, nir_imm_floatN_t(b, -1.0, x->bit_size),
nir_imm_floatN_t(b, +1.0, x->bit_size));
}
static nir_def *
nir_fsat_to_format(nir_builder *b, nir_def *x, enum pipe_format format)
{
if (util_format_is_unorm(format))
return nir_fsat(b, x);
else if (util_format_is_snorm(format))
return nir_fsat_signed(b, x);
else
return x;
}
static nir_def *
load_tilebuffer(nir_builder *b, struct agx_tilebuffer_layout *tib,
uint8_t load_comps, uint8_t bit_size, unsigned rt,
@ -113,6 +131,15 @@ load_tilebuffer(nir_builder *b, struct agx_tilebuffer_layout *tib,
res = nir_f2f32(b, res);
}
/* Some formats like RGB565 are float in the tilebuffer but logically
* normalized. We need to clamp on load to get proper blending semantics, as
* the APIs require clamping here and nir_lower_blend (correctly) assumes
* load_output is clamped. The spilled path is unaffected as the clamping
* implicitly happens when roundtripping to memory.
*/
if (f16)
res = nir_fsat_to_format(b, res, logical_format);
res = nir_sign_extend_if_sint(b, res, logical_format);
return nir_pad_vector(b, res, load_comps);
}