fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 00:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glsl: error on linking if no shaders are attached to program

Browse source 
This applies to OpenGL Core >= 4.5 and OpenGL ES >= 3.1.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
This commit is contained in:
Tapani Pälli 2015-09-03 14:20:46 +03:00
parent 4323e78d3f
commit 69678953d1
1 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/glsl/linker.cpp
View file

@ -3466,6 +3466,25 @@ link_shaders(struct gl_context *ctx, struct gl_shader_program *prog)
prog->Version = max_version;
prog->IsES = is_es_prog;
/* From OpenGL 4.5 Core specification (7.3 Program Objects):
* "Linking can fail for a variety of reasons as specified in the OpenGL
* Shading Language Specification, as well as any of the following
* reasons:
*
* * No shader objects are attached to program.
*
* ..."
*
* Same rule applies for OpenGL ES >= 3.1.
*/
if (prog->NumShaders == 0 &&
((ctx->API == API_OPENGL_CORE && ctx->Version >= 45) ||
(ctx->API == API_OPENGLES2 && ctx->Version >= 31))) {
linker_error(prog, "No shader objects are attached to program.\n");
goto done;
}
/* Some shaders have to be linked with some other shaders present.
*/
if (num_shaders[MESA_SHADER_GEOMETRY] > 0 &&