fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 15:20:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

gallivm: Use first_active_invocation for scalar SSBO loads.

Browse source 
Again, this should reduce the complexity of the LLVM IR we emit in some
cases.  We don't use it for shared loads, due to the noted corner case.

Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21142>
This commit is contained in:
Emma Anholt 2023-02-28 12:30:36 -08:00 • committed by Marge Bot
parent a2b054c8f0
commit 66dff3d39c
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/gallium/auxiliary/gallivm/lp_bld_nir_soa.c
View file

@ -1304,15 +1304,19 @@ static void emit_load_mem(struct lp_build_nir_context *bld_base,
offset = LLVMBuildAShr(gallivm->builder, offset, lp_build_const_int_vec(gallivm, uint_bld->type, shift_val), "");
/* If the address is uniform, then use the address from invocation 0 to load,
* and broadcast to all invocations.
/* If the address is uniform, then use the address from the first active
* invocation 0 to load, and broadcast to all invocations. We can't do
* computed first active invocation for shared accesses (index == NULL),
* though, since those don't do bounds checking and we could use an invalid
* offset if exec_mask == 0.
*/
if (index_and_offset_are_uniform && invocation_0_must_be_active(bld_base)) {
if (index_and_offset_are_uniform && (invocation_0_must_be_active(bld_base) || index)) {
LLVMValueRef ssbo_limit;
LLVMValueRef first_active = first_active_invocation(bld_base);
LLVMValueRef mem_ptr = mem_access_base_pointer(bld_base, load_bld, bit_size, index,
lp_build_const_int32(gallivm, 0), &ssbo_limit);
first_active, &ssbo_limit);
offset = LLVMBuildExtractElement(gallivm->builder, offset, lp_build_const_int32(gallivm, 0), "");
offset = LLVMBuildExtractElement(gallivm->builder, offset, first_active, "");
for (unsigned c = 0; c < nc; c++) {
LLVMValueRef chan_offset = LLVMBuildAdd(builder, offset, lp_build_const_int32(gallivm, c), "");