From 657b8e5264176bf1ce31ac85081234371c4203a9 Mon Sep 17 00:00:00 2001 From: Connor Abbott Date: Thu, 5 Oct 2023 16:24:36 +0200 Subject: [PATCH] vk/graphics_state: Remove bogus assert in CmdSetSampleMaskEXT We're supposed to just ignore samples above what we support, and there's no VU matching this assert. Fixes a crash in dEQP-VK.pipeline.shader_object_unlinked_spirv.extended_dynamic_state.misc.sample_shading_dynamic_sample_count. Reviewed-by: Faith Ekstrand Reviewed-by: Alyssa Rosenzweig Part-of: --- src/vulkan/runtime/vk_graphics_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/vulkan/runtime/vk_graphics_state.c b/src/vulkan/runtime/vk_graphics_state.c index db2bd178e7b..c8ea2545a15 100644 --- a/src/vulkan/runtime/vk_graphics_state.c +++ b/src/vulkan/runtime/vk_graphics_state.c @@ -2646,7 +2646,6 @@ vk_common_CmdSetSampleMaskEXT(VkCommandBuffer commandBuffer, VK_FROM_HANDLE(vk_command_buffer, cmd, commandBuffer); struct vk_dynamic_graphics_state *dyn = &cmd->dynamic_graphics_state; - assert(samples <= MESA_VK_MAX_SAMPLES); VkSampleMask sample_mask = *pSampleMask & BITFIELD_MASK(MESA_VK_MAX_SAMPLES); SET_DYN_VALUE(dyn, MS_SAMPLE_MASK, ms.sample_mask, sample_mask);