diff --git a/.pick_status.json b/.pick_status.json index 627e4fc76f9..30efc7a7ec7 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -364,7 +364,7 @@ "description": "aco: change usesModifiers() considering opsel_hi on packed instructions", "nominated": false, "nomination_type": null, - "resolution": 4, + "resolution": 1, "master_sha": null, "because_sha": null }, diff --git a/src/amd/compiler/aco_ir.h b/src/amd/compiler/aco_ir.h index f8aab8cef67..69a9d977595 100644 --- a/src/amd/compiler/aco_ir.h +++ b/src/amd/compiler/aco_ir.h @@ -1443,8 +1443,12 @@ constexpr bool Instruction::usesModifiers() const noexcept for (unsigned i = 0; i < operands.size(); i++) { if (vop3p->neg_lo[i] || vop3p->neg_hi[i]) return true; + + /* opsel_hi must be 1 to not be considered a modifier - even for constants */ + if (!(vop3p->opsel_hi & (1 << i))) + return true; } - return vop3p->opsel_lo || vop3p->opsel_hi || vop3p->clamp; + return vop3p->opsel_lo || vop3p->clamp; } else if (isVOP3()) { const VOP3A_instruction *vop3 = static_cast(this); for (unsigned i = 0; i < operands.size(); i++) {