From 63f47a970625147211890988a1f300e5f0b36f6f Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 3 Sep 2025 15:56:09 +0200 Subject: [PATCH] panvk: fix up vk1.4 properties These two properties reports how the interaction between MSAA coverage and occlusion queries works. We need to report the correct value here, otherwise applications might misbehave. Fixes: 5ee3c10d1ed ("panvk: advertise vulkan 1.4 on v10+") Reviewed-by: Christoph Pillmayer Part-of: (cherry picked from commit 166d650c10ce28a2fa00d39d8591be98948a4b4c) --- .pick_status.json | 2 +- src/panfrost/vulkan/panvk_vX_physical_device.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index 12df543403a..5a3c9739fc1 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -10004,7 +10004,7 @@ "description": "panvk: fix up vk1.4 properties", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "5ee3c10d1edf4663980e8ea759a58dcc054efb71", "notes": null diff --git a/src/panfrost/vulkan/panvk_vX_physical_device.c b/src/panfrost/vulkan/panvk_vX_physical_device.c index eed5588d610..cd3b83856bc 100644 --- a/src/panfrost/vulkan/panvk_vX_physical_device.c +++ b/src/panfrost/vulkan/panvk_vX_physical_device.c @@ -874,6 +874,10 @@ panvk_per_arch(get_physical_device_properties)( /* Vulkan 1.3 properties */ /* XXX: 1.3 support */ + /* Vulkan 1.4 properties */ + .earlyFragmentMultisampleCoverageAfterSampleCounting = true, + .earlyFragmentSampleMaskTestBeforeSampleCounting = true, + /* VK_EXT_subgroup_size_control */ .minSubgroupSize = pan_subgroup_size(PAN_ARCH), .maxSubgroupSize = pan_subgroup_size(PAN_ARCH),