From 63a6e0ffc9a6f2f01c575d8621dc36cfaf89a59b Mon Sep 17 00:00:00 2001 From: "Eric R. Smith" Date: Thu, 5 Mar 2026 10:22:32 -0400 Subject: [PATCH] pco: fix a typo in the check for optimization looping The count isn't incremented anywhere else. Signed-off-by: Eric R. Smith Reviewed-by: Simon Perretta Fixes: f1b24267d25 ("pco: rework nir processing and passes") (cherry picked from commit 8521051cfa73b22469ec0ed2d58cf71557afd29d) Part-of: --- .pick_status.json | 2 +- src/imagination/pco/pco_nir.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index f70b604e95f..326a95e0de1 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1264,7 +1264,7 @@ "description": "pco: fix a typo in the check for optimization looping", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "f1b24267d25bcf3a29228b705a253a6c4b40b8af", "notes": null diff --git a/src/imagination/pco/pco_nir.c b/src/imagination/pco/pco_nir.c index c674119fc94..ec51364fd1c 100644 --- a/src/imagination/pco/pco_nir.c +++ b/src/imagination/pco/pco_nir.c @@ -448,7 +448,7 @@ static void pco_nir_opt(pco_ctx *ctx, nir_shader *nir, bool algebraic) do { progress = false; - if (count > 1000) { + if (count++ > 1000) { printf("WARNING! Infinite opt loop!\n"); break; }