From 6379a552a72b874eea1b0bbc4c4867a99d683abc Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Thu, 9 Jan 2020 10:53:36 +0100 Subject: [PATCH] v3dv: add a note on interactions between clearing and scissor Part-of: --- src/broadcom/vulkan/v3dv_cmd_buffer.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c index 09e7a7ae80d..35fb0be50ee 100644 --- a/src/broadcom/vulkan/v3dv_cmd_buffer.c +++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c @@ -820,6 +820,12 @@ emit_rcl(struct v3dv_cmd_buffer *cmd_buffer) } } + /* FIXME: the tile buffer clears don't seem to honor the scissor rect + * so if the current combination of scissor + renderArea doesn't cover + * the full extent of the render target we won't get correct behavior. + * We probably need to detect these cases, implement the clearing by + * drawing a rect and skip clearing here. + */ cl_emit(rcl, TILE_RENDERING_MODE_CFG_CLEAR_COLORS_PART1, clear) { clear.clear_color_low_32_bits = clear_color[0]; clear.clear_color_next_24_bits = clear_color[1] & 0xffffff;