fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 06:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Revert "glsl: clone inputs and outputs during linking"

Browse source 
This reverts commit c2ff3485b3.

Ilia and I noticed a memory leak caused by this patch: at least with
fixed-function programs, we clone things using ProgramResourceList as
the context before reralloc makes it non-NULL.

I believe Tapani found other bugs with these patches, so I'm just going
to revert them for now and let him pursue them further.
This commit is contained in:
Kenneth Graunke 2015-06-28 22:17:16 -07:00
parent cae701fc8e
commit 6218c68bec
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/glsl/linker.cpp
View file

@ -2637,9 +2637,7 @@ add_interface_variables(struct gl_shader_program *shProg,
continue; continue;
}; };
/* Clone ir_variable data so that backend is able to free memory. */ if (!add_program_resource(shProg, programInterface, var,
if (!add_program_resource(shProg, programInterface,
var->clone(shProg->ProgramResourceList, NULL),
build_stageref(shProg, var->name) | mask)) build_stageref(shProg, var->name) | mask))
return false; return false;
} }