fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-02 14:28:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pvr: unify code into one condition

Browse source 
gcc 13.2 incorrectly evaluate that first_use is unitialized value.
This should avoid the bug and make code clearner.

Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31476>
This commit is contained in:
David Heidelberg 2024-10-02 17:19:19 +09:00 • committed by Marge Bot
parent 7702520239
commit 61f3294786
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/imagination/vulkan/pvr_hw_pass.c
View file

@ -1691,8 +1691,15 @@ pvr_is_z_replicate_space_available(const struct pvr_device_info *dev_info,
return VK_SUCCESS;
}
/* Find the subpass where the depth is first written. */
/* Get the registers used in any subpass after the depth is first written.
* Start with registers used in the incoming subpass.
*/
result = pvr_copy_alloc(ctx, &combined_alloc, alloc);
if (result != VK_SUCCESS)
return result;
if (hw_render) {
/* Find the subpass where the depth is first written. */
first_use = hw_render->subpass_count;
for (uint32_t i = 0U; i < hw_render->subpass_count; i++) {
struct pvr_renderpass_subpass *subpass = &ctx->subpasses[i];
@ -1703,16 +1710,7 @@ pvr_is_z_replicate_space_available(const struct pvr_device_info *dev_info,
break;
}
}
}
/* Get the registers used in any subpass after the depth is first written.
* Start with registers used in the incoming subpass.
*/
result = pvr_copy_alloc(ctx, &combined_alloc, alloc);
if (result != VK_SUCCESS)
return result;
if (hw_render) {
/* Merge in registers used in previous subpasses. */
for (uint32_t i = first_use; i < hw_render->subpass_count; i++) {
struct pvr_renderpass_subpass *subpass = &ctx->subpasses[i];