fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-22 22:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glcpp: Fix use-after-free error from #undef directive.

Browse source 
By taking advantage of the recently-added hash_table_remove function.

With this change, all existing tests are now valgrind-clean.
This commit is contained in:
Carl Worth 2010-07-19 18:02:12 -07:00 • committed by Ian Romanick
parent d4f239de6e
commit 61ebc01dfe
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/glsl/glcpp/glcpp-parse.y
View file

@ -202,10 +202,7 @@ control_line:
| HASH_UNDEF IDENTIFIER NEWLINE { | HASH_UNDEF IDENTIFIER NEWLINE {
macro_t *macro = hash_table_find (parser->defines, $2); macro_t *macro = hash_table_find (parser->defines, $2);
if (macro) { if (macro) {
/* XXX: Need hash table to support a real way hash_table_remove (parser->defines, $2);
* to remove an element rather than prefixing
* a new node with data of NULL like this. */
hash_table_insert (parser->defines, NULL, $2);
talloc_free (macro); talloc_free (macro);
} }
talloc_free ($2); talloc_free ($2);