fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 20:18:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/bi: v2x16 conversions don't replicate

Browse source 
They swizzle just like anything else.  Technically, we could maybe do a
little better than the generic case for these since they only read 8
bits per 16 bits in the destination but the generic case is correct,
even if it isn't optimal.

Fixes: f7d44a46cd ("pan/bi: Optimize replication")
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
Reviewed-by: Lorenzo Rossi <lorenzo.rossi@collabora.com>
(cherry picked from commit 8dc458225b)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40752>
This commit is contained in:
Faith Ekstrand 2026-03-24 18:09:35 -04:00 • committed by Eric Engestrom
parent 2527900bbc
commit 60df6998b4
2 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2074,7 +2074,7 @@
"description": "pan/bi: v2x16 conversions don't replicate",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "f7d44a46cd424e797a38ef732360e546f093f0ae",
"notes": null

10
src/panfrost/compiler/bifrost/bi_lower_swizzle.c
View file

@ -167,16 +167,6 @@ bi_instr_replicates(bi_instr *I, BITSET_WORD *replicates_16)
case BI_OPCODE_V2F32_TO_V2F16:
return bi_is_value_equiv(I->src[0], I->src[1]);
case BI_OPCODE_V2F16_TO_V2S16:
case BI_OPCODE_V2F16_TO_V2U16:
case BI_OPCODE_V2S16_TO_V2F16:
case BI_OPCODE_V2S8_TO_V2F16:
case BI_OPCODE_V2S8_TO_V2S16:
case BI_OPCODE_V2U16_TO_V2F16:
case BI_OPCODE_V2U8_TO_V2F16:
case BI_OPCODE_V2U8_TO_V2U16:
return true;
/* 16-bit transcendentals are defined to output zero in their
* upper half, so they do not replicate
*/