fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 17:48:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

agx: Fix float copyprop of neg(neg) case

Browse source 
They should cancel each other. Fixes:

   dEQP-GLES2.functional.shaders.random.basic_expression.combined.0

Fixes: 28801b4849 ("agx: Add forward optimizing pass for fmov")
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18380>
(cherry picked from commit 095415cdf7)
This commit is contained in:
Alyssa Rosenzweig 2022-09-02 22:53:59 -04:00 • committed by Dylan Baker
parent f0193e09e1
commit 609949fbcf
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -4522,7 +4522,7 @@
"description": "agx: Fix float copyprop of neg(neg) case", "description": "agx: Fix float copyprop of neg(neg) case",
"nominated": true, "nominated": true,
"nomination_type": 1, "nomination_type": 1,
"resolution": 0, "resolution": 1,
"main_sha": null, "main_sha": null,
"because_sha": "28801b4849371e633eb66dd2c802d44dbb9e3304" "because_sha": "28801b4849371e633eb66dd2c802d44dbb9e3304"
}, },

7
src/asahi/compiler/agx_optimizer.c
View file

@ -81,11 +81,12 @@ agx_is_fmov(agx_instr *def)
static agx_index static agx_index
agx_compose_float_src(agx_index to, agx_index from) agx_compose_float_src(agx_index to, agx_index from)
{ {
if (to.abs) if (to.abs) {
from.neg = false; from.neg = false;
from.abs = true;
}
from.abs |= to.abs; from.neg ^= to.neg;
from.neg |= to.neg;
return from; return from;
} }