From 60664285a91de5c57cb5a963615655722f6ae486 Mon Sep 17 00:00:00 2001 From: Caio Oliveira Date: Thu, 1 Jun 2023 11:12:12 -0700 Subject: [PATCH] nir/print: Do not print raw values MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In many cases the raw value is not really helpful, since we only work with enums and the raw value is already printed for indices without special printing. If an index benefits from having special printing AND the raw value, we can include the printing of the raw value as part of its handler. Reviewed-by: Faith Ekstrand Reviewed-by: Marcin Ślusarz Part-of: --- src/compiler/nir/nir_print.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index 26155ce3228..bb9588a3800 100644 --- a/src/compiler/nir/nir_print.c +++ b/src/compiler/nir/nir_print.c @@ -933,7 +933,6 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, print_state *state) for (unsigned i = 0; i < info->num_indices; i++) { unsigned idx = info->indices[i]; - bool print_raw = true; if (i != 0) fprintf(fp, ", "); switch (idx) { @@ -956,7 +955,6 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, print_state *state) case NIR_INTRINSIC_ATOMIC_OP: { nir_atomic_op atomic_op = nir_intrinsic_atomic_op(instr); fprintf(fp, "atomic_op="); - print_raw = false; switch (atomic_op) { case nir_atomic_op_iadd: fprintf(fp, "iadd"); break; @@ -1251,12 +1249,9 @@ print_intrinsic_instr(nir_intrinsic_instr *instr, print_state *state) default: { unsigned off = info->index_map[idx] - 1; fprintf(fp, "%s=%d", nir_intrinsic_index_names[idx], instr->const_index[off]); - print_raw = false; break; } } - if (print_raw) - fprintf(fp, " /*%d*/", instr->const_index[i]); } fprintf(fp, ")");