fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 22:49:13 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

zink: never use SpvOpImageQuerySizeLod for texel buffers

Browse source 
this is illegal

cc: mesa-stable

affects KHR-GL46.texture_buffer.texture_buffer_texture_buffer_range

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14696>
This commit is contained in:
Mike Blumenkrantz 2022-01-21 09:39:22 -05:00 • committed by Marge Bot
parent 5dc28ccb79
commit 5e748770b9
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
View file

@ -3068,13 +3068,16 @@ emit_tex(struct ntv_context *ctx, nir_tex_instr *tex)
lod = emit_float_const(ctx, 32, 0.0);
if (tex->op == nir_texop_txs) {
SpvId image = spirv_builder_emit_image(&ctx->builder, image_type, load);
/* Additionally, if its Dim is 1D, 2D, 3D, or Cube,
/* Its Dim operand must be one of 1D, 2D, 3D, or Cube
* - OpImageQuerySizeLod specification
*
* Additionally, if its Dim is 1D, 2D, 3D, or Cube,
* it must also have either an MS of 1 or a Sampled of 0 or 2.
* - OpImageQuerySize specification
*
* all spirv samplers use these types
*/
if (tex->sampler_dim != GLSL_SAMPLER_DIM_MS && !lod)
if (!lod && tex_instr_is_lod_allowed(tex))
lod = emit_uint_const(ctx, 32, 0);
SpvId result = spirv_builder_emit_image_query_size(&ctx->builder,
dest_type, image,