fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-26 04:30:34 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

freedreno/drm: Shareable stateobjs

Browse source 
The special case of CS stateobjs can be shared across contexts/threads.
In all other cases, they are private to a single ctx, and it is safe to
make single-threaded assumptions when it comes to fast-paths.

See also commit b74a07a422 ("freedreno/a6xx: Avoid touching long lived
stateobj refcnt").

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40352>
This commit is contained in:
Rob Clark 2026-03-09 12:14:08 -07:00 • committed by Marge Bot
parent b91b0535d8
commit 5e07201b7c
4 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/freedreno/drm/freedreno_ringbuffer.c
View file

@ -79,3 +79,11 @@ fd_ringbuffer_new_object(struct fd_pipe *pipe, uint32_t size)
{
return pipe->funcs->ringbuffer_new_object(pipe, size);
}
struct fd_ringbuffer *
fd_ringbuffer_new_shareable_object(struct fd_pipe *pipe, uint32_t size)
{
struct fd_ringbuffer *ring = fd_ringbuffer_new_object(pipe, size);
ring->flags |= FD_RINGBUFFER_SHAREABLE;
return ring;
}

9
src/freedreno/drm/freedreno_ringbuffer.h
View file

@ -52,8 +52,13 @@ enum fd_ringbuffer_flags {
*/
FD_RINGBUFFER_GROWABLE = 0x4,
/* Indicates an _FD_RINGBUFFER_OBJECT that can be shared
* across threads
*/
FD_RINGBUFFER_SHAREABLE = 0x8,
/* Internal use only: */
_FD_RINGBUFFER_OBJECT = 0x8,
_FD_RINGBUFFER_OBJECT = 0x10,
};
/* A submit object manages/tracks all the state buildup for a "submit"
@ -123,6 +128,8 @@ struct fd_ringbuffer {
*/
struct fd_ringbuffer *fd_ringbuffer_new_object(struct fd_pipe *pipe,
uint32_t size);
struct fd_ringbuffer *
fd_ringbuffer_new_shareable_object(struct fd_pipe *pipe, uint32_t size);
/*
* Helpers for ref/unref with some extra debugging.. unref() returns true if

3
src/freedreno/drm/freedreno_ringbuffer_sp.c
View file

@ -595,7 +595,8 @@ fd_ringbuffer_sp_attach_ring_nonobj(struct fd_ringbuffer *ring,
if (!(target->flags & _FD_RINGBUFFER_OBJECT))
return size;
if (fd_submit->seqno != fd_target->u.last_submit_seqno) {
if ((fd_submit->seqno != fd_target->u.last_submit_seqno) ||
(target->flags & FD_RINGBUFFER_SHAREABLE)) {
for (unsigned i = 0; i < fd_target->u.nr_reloc_bos; i++) {
fd_submit_append_bo(fd_submit, fd_target->u.reloc_bos[i]);
}

2
src/gallium/drivers/freedreno/a6xx/fd6_compute.cc
View file

@ -170,7 +170,7 @@ fd6_launch_grid(struct fd_context *ctx, const struct pipe_grid_info *info) in_dt
struct ir3_shader_variant *v =
ir3_shader_variant(ir3_get_shader(hwcso), key, false, &ctx->debug);
if (v) {
cp->stateobj = fd_ringbuffer_new_object(ctx->pipe, 0x1000);
cp->stateobj = fd_ringbuffer_new_shareable_object(ctx->pipe, 0x1000);
fd_cs cs(cp->stateobj);
with_crb (cs, 9)
cs_program_emit<CHIP>(screen, crb, v);