From 5d72ebf3e7bb392126ce68dcecbdaaa5d05db343 Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Tue, 6 May 2025 20:15:10 -0400 Subject: [PATCH] nvk: Stop printing errors for invalid dma-buf image queries This warning message has been annoying people for a long time. Let's just get rid of it. I don't think it's really helping anyone with anything and it's just burning logging space. Part-of: --- src/nouveau/vulkan/nvk_image.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/nouveau/vulkan/nvk_image.c b/src/nouveau/vulkan/nvk_image.c index a1658ad5bfe..70f89dd9e24 100644 --- a/src/nouveau/vulkan/nvk_image.c +++ b/src/nouveau/vulkan/nvk_image.c @@ -543,12 +543,12 @@ nvk_GetPhysicalDeviceImageFormatProperties2( break; case VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT: - if (!tiling_has_explicit_layout) { - return vk_errorf(pdev, VK_ERROR_FORMAT_NOT_SUPPORTED, - "VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT " - "requires VK_IMAGE_TILING_LINEAR or " - "VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT"); - } + /* VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT requires + * VK_IMAGE_TILING_LINEAR or VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT + */ + if (!tiling_has_explicit_layout) + return VK_ERROR_FORMAT_NOT_SUPPORTED; + ext_mem_props = &nvk_dma_buf_mem_props; break;