fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 11:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

broadcom/qpu: use back BITFIELD64_RANGE for ANYOPMASK

Browse source 
This is the original definition for ANYOPMASK, until we found that
clang raised a warning using the option shift-count-overflow, so we
used an alternative.

That warning was fixed with commit 6e2bb716b0, so let's restore
previous version.

Note that other good thing of that warning being fixed is that now we
can use without warning OP_RANGE with bit 63 (in the case that any
broadcom opcode used that bit)

Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25776>
This commit is contained in:
Alejandro Piñeiro 2023-10-18 10:12:23 +02:00 • committed by Marge Bot
parent 1c619b668d
commit 5cb00f7e77
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/broadcom/qpu/qpu_pack.c
View file

@ -496,10 +496,7 @@ v3d_qpu_flags_pack(const struct v3d_device_info *devinfo,
#define OP_MASK(val) BITFIELD64_BIT(val)
#define OP_RANGE(bot, top) BITFIELD64_RANGE(bot, top - bot + 1)
#define ANYMUX OP_RANGE(0, 7)
/* FIXME: right now ussing BITFIELD64_RANGE to set the last bit raises a
* warning when building with clang using the shift-count-overflow option
*/
#define ANYOPMASK ~0ull
#define ANYOPMASK OP_RANGE(0, 63)
struct opcode_desc {
uint8_t opcode_first;