glsl: Rename variable_entry2 back to variable_entry in struct splitting.

The anonymous namespace should keep these private classes to file scope,
preventing clashes with other symbols of the same name elsewhere.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
Kenneth Graunke 2012-09-19 13:27:57 -07:00
parent ea0d088727
commit 5cadb3ef7e

View file

@ -42,14 +42,10 @@ namespace {
static bool debug = false;
// XXX using variable_entry2 here to avoid collision (MSVC multiply-defined
// function) with the variable_entry class seen in ir_variable_refcount.h
// Perhaps we can use the one in ir_variable_refcount.h and make this class
// here go away?
class variable_entry2 : public exec_node
class variable_entry : public exec_node
{
public:
variable_entry2(ir_variable *var)
variable_entry(ir_variable *var)
{
this->var = var;
this->whole_structure_access = 0;
@ -95,7 +91,7 @@ public:
virtual ir_visitor_status visit_enter(ir_assignment *);
virtual ir_visitor_status visit_enter(ir_function_signature *);
variable_entry2 *get_variable_entry2(ir_variable *var);
variable_entry *get_variable_entry(ir_variable *var);
/* List of variable_entry */
exec_list variable_list;
@ -103,8 +99,8 @@ public:
void *mem_ctx;
};
variable_entry2 *
ir_structure_reference_visitor::get_variable_entry2(ir_variable *var)
variable_entry *
ir_structure_reference_visitor::get_variable_entry(ir_variable *var)
{
assert(var);
@ -112,12 +108,12 @@ ir_structure_reference_visitor::get_variable_entry2(ir_variable *var)
return NULL;
foreach_iter(exec_list_iterator, iter, this->variable_list) {
variable_entry2 *entry = (variable_entry2 *)iter.get();
variable_entry *entry = (variable_entry *)iter.get();
if (entry->var == var)
return entry;
}
variable_entry2 *entry = new(mem_ctx) variable_entry2(var);
variable_entry *entry = new(mem_ctx) variable_entry(var);
this->variable_list.push_tail(entry);
return entry;
}
@ -126,7 +122,7 @@ ir_structure_reference_visitor::get_variable_entry2(ir_variable *var)
ir_visitor_status
ir_structure_reference_visitor::visit(ir_variable *ir)
{
variable_entry2 *entry = this->get_variable_entry2(ir);
variable_entry *entry = this->get_variable_entry(ir);
if (entry)
entry->declaration = true;
@ -138,7 +134,7 @@ ir_visitor_status
ir_structure_reference_visitor::visit(ir_dereference_variable *ir)
{
ir_variable *const var = ir->variable_referenced();
variable_entry2 *entry = this->get_variable_entry2(var);
variable_entry *entry = this->get_variable_entry(var);
if (entry)
entry->whole_structure_access++;
@ -200,12 +196,12 @@ public:
void split_deref(ir_dereference **deref);
void handle_rvalue(ir_rvalue **rvalue);
variable_entry2 *get_splitting_entry(ir_variable *var);
variable_entry *get_splitting_entry(ir_variable *var);
exec_list *variable_list;
};
variable_entry2 *
variable_entry *
ir_structure_splitting_visitor::get_splitting_entry(ir_variable *var)
{
assert(var);
@ -214,7 +210,7 @@ ir_structure_splitting_visitor::get_splitting_entry(ir_variable *var)
return NULL;
foreach_iter(exec_list_iterator, iter, *this->variable_list) {
variable_entry2 *entry = (variable_entry2 *)iter.get();
variable_entry *entry = (variable_entry *)iter.get();
if (entry->var == var) {
return entry;
}
@ -234,7 +230,7 @@ ir_structure_splitting_visitor::split_deref(ir_dereference **deref)
if (!deref_var)
return;
variable_entry2 *entry = get_splitting_entry(deref_var->var);
variable_entry *entry = get_splitting_entry(deref_var->var);
if (!entry)
return;
@ -269,8 +265,8 @@ ir_structure_splitting_visitor::visit_leave(ir_assignment *ir)
{
ir_dereference_variable *lhs_deref = ir->lhs->as_dereference_variable();
ir_dereference_variable *rhs_deref = ir->rhs->as_dereference_variable();
variable_entry2 *lhs_entry = lhs_deref ? get_splitting_entry(lhs_deref->var) : NULL;
variable_entry2 *rhs_entry = rhs_deref ? get_splitting_entry(rhs_deref->var) : NULL;
variable_entry *lhs_entry = lhs_deref ? get_splitting_entry(lhs_deref->var) : NULL;
variable_entry *rhs_entry = rhs_deref ? get_splitting_entry(rhs_deref->var) : NULL;
const glsl_type *type = ir->rhs->type;
if ((lhs_entry || rhs_entry) && !ir->condition) {
@ -320,7 +316,7 @@ do_structure_splitting(exec_list *instructions)
/* Trim out variables we can't split. */
foreach_iter(exec_list_iterator, iter, refs.variable_list) {
variable_entry2 *entry = (variable_entry2 *)iter.get();
variable_entry *entry = (variable_entry *)iter.get();
if (debug) {
printf("structure %s@%p: decl %d, whole_access %d\n",
@ -342,7 +338,7 @@ do_structure_splitting(exec_list *instructions)
* components.
*/
foreach_iter(exec_list_iterator, iter, refs.variable_list) {
variable_entry2 *entry = (variable_entry2 *)iter.get();
variable_entry *entry = (variable_entry *)iter.get();
const struct glsl_type *type = entry->var->type;
entry->mem_ctx = ralloc_parent(entry->var);