From 5c28afdc7fd701e1f55e40a5be100c6072edec2a Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 21 Jan 2022 10:32:51 -0500 Subject: [PATCH] zink: simplify buffer case for zink_resource_object_init_storage() this is a no-op, but leave the case to simplify the caller Reviewed-by: Dave Airlie Part-of: --- src/gallium/drivers/zink/zink_resource.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/gallium/drivers/zink/zink_resource.c b/src/gallium/drivers/zink/zink_resource.c index c77198050ec..42b70c58fa6 100644 --- a/src/gallium/drivers/zink/zink_resource.c +++ b/src/gallium/drivers/zink/zink_resource.c @@ -1818,15 +1818,7 @@ zink_resource_object_init_storage(struct zink_context *ctx, struct zink_resource if (res->base.b.bind & PIPE_BIND_SHADER_IMAGE) return true; if (res->obj->is_buffer) { - if (res->base.b.bind & PIPE_BIND_SHADER_IMAGE) - return true; - - VkBuffer buffer = zink_resource_tmp_buffer(screen, res, 0, PIPE_BIND_SHADER_IMAGE, NULL); - if (!buffer) - return false; - util_dynarray_append(&res->obj->tmp, VkBuffer, res->obj->buffer); - res->obj->buffer = buffer; - res->base.b.bind |= PIPE_BIND_SHADER_IMAGE; + unreachable("zink: all buffers should have this bit"); } else { zink_fb_clears_apply_region(ctx, &res->base.b, (struct u_rect){0, res->base.b.width0, 0, res->base.b.height0}); zink_resource_image_barrier(ctx, res, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, 0, 0);